Skip to content

feat: Rokt callback support #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: Rokt callback support #17

wants to merge 3 commits into from

Conversation

sahil-rokt
Copy link
Contributor

@sahil-rokt sahil-rokt commented Apr 16, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • {provide a thorough description of the changes}

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@sahil-rokt sahil-rokt force-pushed the feat/Rokt_Callback_Support branch from dc0949a to 98a36b8 Compare April 16, 2025 04:39
@sahil-rokt sahil-rokt changed the base branch from feat/rokt_example_app to feat/Integrate_Example_App April 16, 2025 05:00
@sahil-rokt sahil-rokt force-pushed the feat/Rokt_Callback_Support branch from 98a36b8 to 3dffb40 Compare April 16, 2025 05:01
@sahil-rokt sahil-rokt changed the title Feat Rokt callback support feat: Rokt callback support Apr 16, 2025
@sahil-rokt sahil-rokt force-pushed the feat/Rokt_Callback_Support branch from 3dffb40 to 3365dec Compare April 16, 2025 05:03
Mansi-mParticle
Mansi-mParticle reviewed Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but let's wait for the android code updated. Once that's done, I'll go ahead and approve the PR.

@sahil-rokt sahil-rokt force-pushed the feat/Rokt_Callback_Support branch from 3365dec to e77d8ab Compare April 17, 2025 01:01
@sahil-rokt sahil-rokt force-pushed the feat/Rokt_Callback_Support branch from e77d8ab to ab68295 Compare April 17, 2025 01:06
@sahil-rokt
Copy link
Contributor Author

The code looks good to me, but let's wait for the android code updated. Once that's done, I'll go ahead and approve the PR.

Review this PR too, as I have made the changes on top of the branch feat/Integrate_Example_App.

@Mansi-mParticle Mansi-mParticle changed the base branch from feat/Integrate_Example_App to development May 12, 2025 13:57
@Mansi-mParticle Mansi-mParticle mentioned this pull request May 12, 2025
Merged
1 task
@Mansi-mParticle
Copy link
Collaborator

This PR has been cherry-picked and the code has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mansi-mParticle Mansi-mParticle Mansi-mParticle left review comments

@rmi22186 rmi22186 Awaiting requested review from rmi22186

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahil-rokt @Mansi-mParticle